search

ProfessionalWiki / Bootstrap

Provides the Bootstrap 4 web front-end framework to MediaWiki skins and extensions
https://www.mediawiki.org/wiki/Extension:Bootstrap
Other
14 stars 13 forks source link

Improve WMF CI compatibility #36

Closed cicalese closed 4 years ago

cicalese commented 4 years ago

Why would you inherit from MediaWikiTestCase when inheriting from TestCase is sufficient?

This is an attempt to get the tests to pass in Wikimedia CI (see T253321 and 597812 ). I tried to address all deviations from the suggested instructions that might be introducing problems in that environment.

JeroenDeDauw commented 4 years ago

I very much doubt not using MediaWikiTestCase is causing any of the problems, and certainly hope so.

IMO the recommendation to extend this class by default is really poor advice. Inheritance is an extreme form of coupling. Inheriting concrete code comes with a high cost. Doing so over a component boundary only increases this cost.

cicalese commented 4 years ago

The Wikimedia CI failures seem to be independent of the differences, so I've reverted the change in base class and am only retaining the changes to the unnecessary bootstrapping.