I included the .map files otherwise the browser developer console complains about missing .map files when using the query parameter ?debug=true.
With regards to manual testing with Chameleon (latest master), I did quick checks for the following:
default cmln breakpoint works across all Chameleon layouts
5 default Chameleon layout components still visible (not directly related to Bootstrap, but just to make sure something didn't become invisible)
navbars collapse and expand correctly
navbar submenus collapse and expand correctly
I could not find any Bootstrap-related style regressions (except for some very, very minor spacing differences). I created a rough (and probably incomplete) extension to add a special page to preview Bootstrap styles (https://github.com/malberts/BootstrapExamples). Using that extension I can quickly compare whether default Bootstrap HTML still looks fine:
With regards to automated testing - but unrelated to this PR - I started looking at building UI functional and visual snapshot tests for Bootstrap+Chameleon using Cypress. This is to check pages, components, layouts and Bootstrap style changes. With visual snapshots (screenshots) I can compare the styling and set a similarity threshold. By using my BootstrapExamples page I can compare smaller screenshots per Bootstrap component. I am trying to set it up in Docker so that there is a consistent Mediawiki+Bootstrap+Chameleon setup. However, Cypress does some request interception magic and I am having some issues with it when I use your mw-docker image. It works fine when I use my own nginx-based image. I think there is some apache/nginx config differences that I am missing, but I won't go into detail on this PR.
This is the latest Bootstrap 4 and replaces my previous PR (https://github.com/ProfessionalWiki/Bootstrap/pull/45).
I included the .map files otherwise the browser developer console complains about missing .map files when using the query parameter
?debug=true.With regards to manual testing with Chameleon (latest master), I did quick checks for the following:
cmlnbreakpoint works across all Chameleon layoutsI could not find any Bootstrap-related style regressions (except for some very, very minor spacing differences). I created a rough (and probably incomplete) extension to add a special page to preview Bootstrap styles (https://github.com/malberts/BootstrapExamples). Using that extension I can quickly compare whether default Bootstrap HTML still looks fine:
With regards to automated testing - but unrelated to this PR - I started looking at building UI functional and visual snapshot tests for Bootstrap+Chameleon using Cypress. This is to check pages, components, layouts and Bootstrap style changes. With visual snapshots (screenshots) I can compare the styling and set a similarity threshold. By using my BootstrapExamples page I can compare smaller screenshots per Bootstrap component. I am trying to set it up in Docker so that there is a consistent Mediawiki+Bootstrap+Chameleon setup. However, Cypress does some request interception magic and I am having some issues with it when I use your mw-docker image. It works fine when I use my own nginx-based image. I think there is some apache/nginx config differences that I am missing, but I won't go into detail on this PR.