ProfessionalWiki / Bootstrap

Provides the Bootstrap 4 web front-end framework to MediaWiki skins and extensions
https://www.mediawiki.org/wiki/Extension:Bootstrap
Other
14 stars 13 forks source link

scss update #70

Closed robis24 closed 1 year ago

robis24 commented 1 year ago

update scss for MediaWiki 1.39

malberts commented 1 year ago

Strictly speaking this will require a bump in extension major version, since the SCSS dependency raises minimum requirements. But maybe by now nobody using this still cares about MW <1.35 so we can just do a 4.7.0 with raised requirements.

Otherwise I think it could also work if the version is "~3.0|~2.0", because that wouldn't raise the minimum requirements here since you can still use the older version of SCSS. At the moment the latest SCSS 2.x and SCSS 3.x are functionally the same.

I'd prefer to use the 5.0.0 branch of this extension for Bootstrap 5.3.

Pieter-S-96 commented 1 year ago

But maybe by now nobody using this still cares about MW <1.35 so we can just do a 4.7.0 with raised requirements.

robis and I work on projects together. Wherever we use 1.35 and requirements for composer dependencies aren't met, the most trivial solution is to downgrade some versions. For up-to-date chameleon users the minimum required version is still 4.5.0 so in our case we wouldn't be bothered to stay behind a minor version or two. In other words, the people who still care abot MW <1.35 will have to make do with older extension versions :)

The main reason for this fix was a fatal error in the scss resource loader on a new environment, which gets resolved by this dependency change.

Otherwise I think it could also work if the version is "~3.0|~2.0", because that wouldn't raise the minimum requirements here since you can still use the older version of SCSS.

That would be the best of both worlds!

malberts commented 1 year ago

I updated it with both SCSS versions and released a new version 4.6.2.