ProfessionalWiki / ExternalContent

MediaWiki extension that allows embedding external content
https://professional.wiki/en/news/external-content
GNU General Public License v2.0
7 stars 4 forks source link

feature: add Cache expiry settings #17

Open freephile opened 2 years ago

freephile commented 2 years ago

Jeroen, this is my first attempt.

I know I can't call updateCacheExpiry() on a null parser object (see error) but I'm not sure what to do... I was going to check hooks and see if it needs to be implemented in a different hook function besides onParserFirstCallInit()

Error from line 23 of /var/www/html/extensions/ExternalContent/src/EntryPoints/MediaWikiHooks.php: Call to a member function updateCacheExpiry() on null

Can you look at my efforts and give me any feedback?

Aside: I would normally do this in a feature branch, but had some trouble getting VSCode in a container to work with GitHub, and the terminal was constrained (no prompts) so I had to do some docker file copies back to my host machine and then still ended up pushing to 'master' in my forked repo :-(