ProfessionalWiki / ExternalContent

MediaWiki extension that allows embedding external content
https://professional.wiki/en/news/external-content
GNU General Public License v2.0
6 stars 4 forks source link

specificLines is broken #49

Closed malberts closed 8 months ago

malberts commented 8 months ago

Follow-up to #44

When using this wikitext:

{{#embed:https://github.com/ProfessionalWiki/ExternalContent/blob/master/src/EmbedExtensionFactory.php|line|specificLines=10-20}}

The page looks like this: Screenshot_20231027_131235

malberts commented 8 months ago

It looks like the HTML has the hide-line class in the wrong place: Screenshot_20231027_131657

When manually removing the class from the DOM there is a spacing issue on the first line, but also that <?php isn't supposed to be there: Screenshot_20231027_131802

This is the full code with <?php on line 1: Screenshot_20231027_132015