ProfessionalWiki / ExternalContent

MediaWiki extension that allows embedding external content
https://professional.wiki/en/news/external-content
GNU General Public License v2.0
7 stars 4 forks source link

Unexpected behavior when using Copy button along with showLines parameter #58

Closed malberts closed 11 months ago

malberts commented 11 months ago

Use this wikitext:

{{#embed:https://github.com/ProfessionalWiki/ExternalContent|lang=md|lineNumbers|showLines=1-3,5}}

Screenshot_20231031_141519

Then click the Copy button. The copied text is the full file, but with broken whitespace: Screenshot_20231031_141702


The copy button behavior should do one of the following:

  1. copy the visible lines
  2. copy the original full file correctly

Most likely (1) is more the expected behavior.

JeroenDeDauw commented 11 months ago

Yes, should only copy visible lines. Though copying the entire file is already better than copying a messed up version of the entire file.