search

ProfessionalWiki / Maps

🗺 Maps is the MediaWiki extension that enables visualization of geographic data with dynamic embedded maps.
https://maps.extension.wiki
Other
73 stars 62 forks source link

Use user from request context #759

Open prudloff-insite opened 10 months ago

prudloff-insite commented 10 months ago

This fixes #758 for us but it might not be the correct solution.

I find it a bit strange that Parser::getUserIdentity() does not check if Parser::getOptions() returns null before trying to use its result. (The documentation of Parser::getOptions() acknowledges that it can return null.)

JeroenDeDauw commented 10 months ago

I'm not sure either that your change is correct. It seems safer to get the user from the Parser object rather than via a global.