Clarify when user can(not) approve

ProfessionalWiki / PageApprovals

Increase trust in your wiki knowledge base via approval workflows

https://professional.wiki/en/extension/page-approvals

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

Clarify when user can(not) approve #109

Closed malberts closed 3 months ago

malberts commented 3 months ago

When on a page, it is not clear whether I am allowed to approve a page:

the indicator/button looks the same
the mouse hover looks the same and suggests it is clickable

The indicator/button can be perceived as "broken" if it looks exactly the same.

clarify.webm

AC:

Remove at least the hover similarities (cursor)
Ideally make the indicator visually different for approvers and non-approvers

waximabbax commented 3 months ago

I remember suggesting an arrow on the right side of the approved badge button only for the approver to make it look like it's a dropdown with options.

dropdown

Example: custom-dropdown-button

JeroenDeDauw commented 3 months ago

@waximabbax sound reasonable to me, but don't forget this AC:

Remove at least the hover similarities (cursor)

JeroenDeDauw commented 3 months ago

Slite does not have a visual icon to indicate your can click the approval thing. I'm getting the impression you can always change the approval status. Or maybe I'm wrong and normal users cannot. Difficult to test quickly. But for sure they do not have an icon, and when the doc is not verified, they show "verify this doc" rather than "this doc is not verified"

https://github.com/user-attachments/assets/cf5ed9bf-bb6c-4f80-8717-7c58d65247dd

malberts commented 3 months ago

That popup contains both actions and info. So theoretically that popup could always be triggered, even if I did not have permission to do any of those actions.