ProfessionalWiki / chameleon

Provides a highly flexible and customizable skin using Bootstrap 4
https://www.mediawiki.org/wiki/Skin:Chameleon
Other
114 stars 62 forks source link

Echo support #237

Closed malberts closed 3 years ago

malberts commented 3 years ago

Fixes: #3 Fixes: #83 Fixes: #90

s7eph4n commented 3 years ago

When introducing new components, remember to also update https://github.com/ProfessionalWiki/chameleon/blob/master/layouts/layout.rng It is admittedly not straight-forward, but it allows to check that a layout file is at least formally correct.

malberts commented 3 years ago

Thanks for reminding me. I saw that file and was wondering about how to update it. Is there a specific tool you used before, or do you edit it by hand?

Edit: I found a command line tool jing to validate the .rng file. I will edit it by hand and make sure it passes that validation.

s7eph4n commented 3 years ago

I always edited it by hand. I don't know if there is an editor available.

malberts commented 3 years ago

@s7eph4n I updated layout.rng. Does that look about right?

s7eph4n commented 3 years ago

I think it looks good. 👍

malberts commented 3 years ago

@JeroenDeDauw I rewrote a bunch of the code here. Primarily to simplify it and hopefully also to improve the code a bit.

Changes:

I'm not going to make big changes again. If the code is fine I'm going to start the 3.2.0 release after merging.

JeroenDeDauw commented 3 years ago

Needs a rebase

malberts commented 3 years ago

Rebased. Do you want me to squash the commits further?