search

ProfessionalWiki / chameleon

Provides a highly flexible and customizable skin using Bootstrap 4
https://www.mediawiki.org/wiki/Skin:Chameleon
Other
116 stars 62 forks source link

Replace isLoggedIn() #297

Closed malberts closed 2 years ago

malberts commented 2 years ago

Fixes: #295

JeroenDeDauw commented 2 years ago

Does isRegistered do the same as isLoggedIn?!

malberts commented 2 years ago

Yes. isLoggedIn wraps isRegistered and the deprecation note suggests calling it directly. https://www.mediawiki.org/wiki/Release_notes/1.35#Changes_since_MediaWiki_1.35.1

bovender commented 2 years ago

@malberts Would it please be possible to include this in a release, so I can update the skin via Composer? Currently my wiki shows a deprecation message on every page. Thanks so much!

malberts commented 2 years ago

@bovender I think we can probably do the version 4 release soon, however I still need to make sure there are no major issues with MW 1.37 (although all unit tests pass already).

In the meantime, you can use this in your composer file to get the latest master code:

"mediawiki/chameleon-skin": "dev-master",
bovender commented 2 years ago

@malberts Thanks a million, didn't mean to rush you, the trick with "dev-master" is perfect for me right now.