search

ProfessionalWiki / chameleon

Provides a highly flexible and customizable skin using Bootstrap 4
https://www.mediawiki.org/wiki/Skin:Chameleon
Other
116 stars 62 forks source link

Fix deprecated MW 1.37 ResourceModule features #307

Closed malberts closed 1 year ago

malberts commented 2 years ago

When using MW 1.37 some deprecation warnings are visible in the browser's dev console. Originally reported here: https://github.com/ProfessionalWiki/chameleon/issues/304#issuecomment-1013006056 Currently it seems like all the necessary styles are still loaded, so it doesn't break anything.

The content and legacy features are deprecated: https://github.com/ProfessionalWiki/chameleon/blob/master/skin.json#L46

~And the external link style is also deprecated: https://github.com/ProfessionalWiki/chameleon/blob/master/src/Hooks/SetupAfterCache.php#L270~ Fixed in #374

In both cases the new ResourceModule features must be used, while keeping backward compatibility.

Ideas:

jdlrobson commented 2 years ago

Update: The styles associated with the legacy feature was just removed as part of https://phabricator.wikimedia.org/T304325

https://www.mediawiki.org/wiki/Manual:ResourceLoaderSkinModule#For_skins_deprecating_the_legacy_feature has some guidelines on what to do.

jdlrobson commented 1 year ago

Note in 1.39 all styles associated with legacy have been removed. You'll likely want to patch this as part of 1.39.

malberts commented 1 year ago

This can now follow the same approach as #374.