search

ProfessionalWiki / chameleon

Provides a highly flexible and customizable skin using Bootstrap 4
https://www.mediawiki.org/wiki/Skin:Chameleon
Other
115 stars 63 forks source link

Resources not being applied on MediaWiki 1.38 #337

Closed Universal-Omega closed 2 years ago

Universal-Omega commented 2 years ago

See https://beta.miraheze.org/wiki/Main_Page?useskin=chameleon. It was working fine before 1.38, doesn't seem to be now. I don't see anything helpful in logs either.

malberts commented 2 years ago

When you run in debug mode, you can look for SCSS compilation errors in individual CSS requests. If you filter on "zzz" in the browser's dev tools you'll find this: Screenshot_20220608_083818

I'm getting 503 errors occasionally when using debug mode, but when I open this URL directly I can see a SCSS compilation error: https://beta.betaheze.org/w/load.php?debug=1&lang=en&modules=zzz.ext.bootstrap.styles&only=styles&skin=chameleon

/* SCSS compile error: File skins/chameleon/resources/styles/_functions.scss on line 29 ERROR: 'There is no unit conversion for ""'
: skins/chameleon/resources/styles/_functions.scss on line 29, at column 3
Call Stack:
#0 function abs extensions/Bootstrap/resources/bootstrap/scss/vendor/_rfs.scss on line 55
#1 function divide extensions/Bootstrap/resources/bootstrap/scss/vendor/_rfs.scss on line 173
#2 mixin rfs extensions/Bootstrap/resources/bootstrap/scss/vendor/_rfs.scss on line 223
#3 mixin font-size skins/chameleon/resources/styles/Components/MainContent.scss on line 57
#4 import skins/chameleon/resources/styles/Components/MainContent.scss skins/chameleon/resources/styles/chameleon.scss on line 29
#5 import skins/chameleon/resources/styles/chameleon.scss (unknown file) on line 1*/

Firstly, can you try to update Chameleon to a more recent version? The commit version shown on your Special:Version (a923c46) is from October 2021, but version 4.0.0 was only released in January 2022. The unreleased 4.0.0 was hanging around for a while, unfortunately.

If updating Chameleon doesn't solve it, the error refers to this: MainContent.scss on line 57: https://github.com/ProfessionalWiki/chameleon/blob/1910bf1c7df5635f7d5f432dded73ae1333501aa/resources/styles/Components/MainContent.scss#L56-L58 Do you perhaps have custom SCSS where you override $font-size-sm?

malberts commented 2 years ago

I remember now. This is most likely related to a Bootstrap 4.6.1 compatibility issue that was fixed in Chameleon 4.1.0: https://github.com/ProfessionalWiki/chameleon/commit/2e703bae2abd7c8e99f932907f1e195ae9fe0971

You have the latest version of the Bootstrap MW extension, which means you've got Bootstrap 4.6.1. So you will definitely need to upgrade Chameleon.

Universal-Omega commented 2 years ago

Thanks, I upgraded it, but now it gives:

Class 'FileFetcher\SimpleFileFetcher' not found
from /srv/mediawiki/w/skins/chameleon/src/Chameleon.php(137)
#0 /srv/mediawiki/w/skins/chameleon/src/Chameleon.php(124): Skins\Chameleon\Chameleon->getComponentFactory()
#1 /srv/mediawiki/w/includes/skins/SkinTemplate.php(216): Skins\Chameleon\Chameleon->setupTemplateForOutput()
#2 /srv/mediawiki/w/skins/chameleon/src/Chameleon.php(112): SkinTemplate->prepareQuickTemplate()
#3 /srv/mediawiki/w/includes/skins/SkinTemplate.php(133): Skins\Chameleon\Chameleon->prepareQuickTemplate()
#4 /srv/mediawiki/w/includes/skins/SkinTemplate.php(150): SkinTemplate->generateHTML()
#5 /srv/mediawiki/w/includes/OutputPage.php(2807): SkinTemplate->outputPage()
#6 /srv/mediawiki/w/includes/MediaWiki.php(924): OutputPage->output(boolean)
#7 /srv/mediawiki/w/includes/MediaWiki.php(937): MediaWiki::{closure}()
#8 /srv/mediawiki/w/includes/MediaWiki.php(564): MediaWiki->main()
#9 /srv/mediawiki/w/index.php(53): MediaWiki->run()
#10 /srv/mediawiki/w/index.php(46): wfIndexMain()
#11 {main}
malberts commented 2 years ago

You'll need to update the composer dependencies.

Universal-Omega commented 2 years ago

Ah, works now. Thank you! Sorry for the issue, I thought we were on latest, some how we missed chameleon when upgrading al of our extensions.