search

ProfessionalWiki / chameleon

Provides a highly flexible and customizable skin using Bootstrap 4
https://www.mediawiki.org/wiki/Skin:Chameleon
Other
115 stars 63 forks source link

Inconsistent new line behaviour in Visual Editor #339

Open Michael-Z-Freeman opened 1 year ago

Michael-Z-Freeman commented 1 year ago

MediaWiki | 1.38.1 PHP | 7.4.3 (cgi-fcgi) Chameleon | 4.1.0 Bootstrap | 4.6.0

I suspect this to be a Visual Editor issue but I put this here anyway.

Hi. I have a page where I use alternating block quotes and paragraphs. However sometimes its as if new lines are ignored. At one place on the page Visual Editor shows two new line icons and the actual page shows the paragraph as contiguous with the text next to it when it should be a new paragraph. wiki.txt Web capture_9-7-2022_12490_liberation-map michaelzfreeman org Web capture_9-7-2022_123951_liberation-map michaelzfreeman org

malberts commented 1 year ago

I also think this is not a Chameleon issue, but to be sure, can you do an edit in VE that causes the incorrect newline behavior and then check what it looks like when you use the Vector skin?

Michael-Z-Freeman commented 1 year ago

Ok got to the bottom of this. It is and it isn't a Chameleon issue. Chameleon does not cause the new line behaviour which is a peculiarity of Mediawiki in a paragraph/block quote where two new lines are needed to create a line break. This does not happen in a standard paragraph. This also has the effect of creating what looks like two new lines in the block quote whereas a normal paragraph only has one. I tested this in Vector.

So the two new lines behaviour. I eventually realised why it looked so wrong to me. This is because block quotes in Chameleon are missing the grey bar that the Vector block quote put's down its left hand side. So this is more to do with issue https://github.com/ProfessionalWiki/chameleon/issues/222