search

ProfessionalWiki / chameleon

Provides a highly flexible and customizable skin using Bootstrap 4
https://www.mediawiki.org/wiki/Skin:Chameleon
Other
115 stars 63 forks source link

Provide a 'title' attribute to Toolbox's dropdown-toggle button #350

Closed mdoggydog closed 1 year ago

mdoggydog commented 1 year ago

This commit adds the machinery for providing a title attribute to the dropdown toggle <a> element of the Toolbox menu. Following the usual MediaWiki scheme for tooltips, the title attribute will be populated with the contents of MediaWiki:Tooltip-p-tb (if that page has been created on the wiki).

mdoggydog commented 1 year ago

A side-note:

The <a> element of the Toolbox dropdown-toggle seems to be the correct element to carry the title attribute: if you hover over the toggle in the navbar, you get a tooltip as expected/desired. (Within the toolbox's dropdown menu, the <a> elements are already getting the proper title attributes and producing the proper tooltips.)

In the NavMenu component, however, the title attribute is applied to the top-level wrapper <div>. This does yield a tooltip when hovering over the toggle button. But, it also yields the identical tooltip text on each menu item that does not have its own tooltip defined, instead of leaving those items without a tooltip.

I think this behavior in NavMenu is broken, and the title attribute should be moved to the toggle <a> element. I can make a PR for that, too....

mdoggydog commented 1 year ago

...but I will wait to do that until after PR #349 is resolved (since it would touch the same code).

malberts commented 1 year ago

I think this behavior in NavMenu is broken, and the title attribute should be moved to the toggle <a> element. I can make a PR for that, too....

I think you are right. I cannot immediately think of a major use case where the current behavior is needed.

On a different note, do you have more changes/fixes upcoming (besides the title fix)? We haven't had a release in a while, so once you're done it might be time to do that.

mdoggydog commented 1 year ago

I think this behavior in NavMenu is broken, and the title attribute should be moved to the toggle <a> element. I can make a PR for that, too....

I think you are right. I cannot immediately think of a major use case where the current behavior is needed.

Great --- I've submitted #352 to fix that.

On a different note, do you have more changes/fixes upcoming (besides the title fix)? We haven't had a release in a while, so once you're done it might be time to do that.

That would be great. I have 5 more items on my chameleon todo list: two small CSS tweaks/fixes, and three features for navbar-related content. I anticipate asking for advice on a couple of the features. I should be able to get PR's and/or issues for all of five filed in the next couple of days, and have them fully resolved in under two weeks, if that seems reasonable.

mdoggydog commented 1 year ago

I forgot to circle back to this thread earlier, but, for the sake of completeness, the PR's I submitted for my "5 more items" are #353, #354, #355, #357, and #358.