StickyTOC hide/show does not work

ProfessionalWiki / chameleon

Provides a highly flexible and customizable skin using Bootstrap 4

https://www.mediawiki.org/wiki/Skin:Chameleon

Other

115 stars 63 forks source link

StickyTOC hide/show does not work #408

Closed krabina closed 6 months ago

krabina commented 7 months ago

Ever since the new StickyTOC component was implemented (thank you, btw!), the hide/show did never work for me. Tested in FF and Chrome. No errors in the console. In my wiki set to German the labels are "Verbergen", "Anzeigen". Using MW 1.39/Chameleon 4.3.0 Did also not work om MW 1.35.

D-Groenewegen commented 6 months ago

The request for that feature seems to be #390, which is still open. To go by @malbert's comment in #396, I suspect it wasn't ready for use just yet.

malberts commented 6 months ago

I believe this was fixed in a bigger open PR: https://github.com/ProfessionalWiki/chameleon/pull/405

We can extract just the fix for the hide/show in a smaller PR.