search

Professor-Melvin / ElgatoWaveLinkSDK

SDK For Elgato Wave Link Software
GNU General Public License v3.0
9 stars 1 forks source link

Wavelink Performance #19

Open oddbear opened 2 years ago

oddbear commented 2 years ago

Hi have you seen any performance issues with this SDK when running over time?

Trying to figure out if this is a issue with my plugin or with the SDK. Audio crackling, slowdowns, Wave Link crashes etc., usually takes a couple of hours or so to occur.

See thread: https://github.com/oddbear/Loupedeck.WaveLink.Plugin/issues/2#issuecomment-1212617101

And to quote CoreParadox Great work, I look forward to using it! Since this is almost only your work, I need to forward this kudos to you... credit where credit is due... So from me also: Great work. 👍

Professor-Melvin commented 2 years ago

I never actually got around to making the project that this library was for, so I've never ran it for a long period of time.

I'll setup it up over the weekend and leave it running to see if I can get the same. In theory, the library shouldn't affect anything like this as I'm just copying how their own JS library does it but who knows

CoreParadox would be right and there is some black box stuff happening that I'm not handling correctly (Could be valid as there might be some events coming though over time that I've never gotten due to only developing rather than using the library and I'm meant to be responding to them in a certain way)

So yeah, I'll try test this over time this weekend and see what I find

Thanks very much! haha And thank you to you too for using the library, never thought anyone would when I first published it

CoreParadox commented 2 years ago

Just to add on, it seemingly occurs at random for me, sometimes it's immediately after starting, sometimes it's several hours after running it.

Professor-Melvin commented 2 years ago

Just an update I have tried to recreated this but I haven't seen the issue arise

@oddbear, are you also running the SteamDeck plugin along side your Loupedeck plugin? I haven't had the chance to run it along side my steam deck for a long period of time like how how Core mentioned, I'm wondering if it doesn't handle multiple connections well

oddbear commented 2 years ago

I don't, but I tried running the Test program, and the Loupedeck plugin. It might be that the audio issues at my end just is my computer beeing a little unstable.

For the plugin I have tried to separated the logic from the SDK by using Channels. My theory is that maybe Wave Link is blocked and gets issues when sending information. Need to do a lot more testing though.

CoreParadox commented 2 years ago

Hey guys, somewhere between oddbear's plugin updates, and my recent re-install of windows, the problem has seemingly magically disappeared, which is both a blessing and a curse I suppose, will update if it comes up again and we can take some debugging steps :)

Professor-Melvin commented 2 years ago

Thanks for the update Core!

I'll leave this bug open in case it comes up again, but it may just be a weird environment thing Just worrying that you both had it, please let me know if either of you see the issue again