search

ProfessorAmanda / econsimulations

This repository provides the code underlying simulations for teaching statistics and econometrics. The project site, which includes teaching materials as well as the link to the simulations, is located here: https://amandagreggeconomics.com/statistics-simulations-project/
Other
1 stars 0 forks source link

Updating based on recent changes #317

Closed ProfessorAmanda closed 2 years ago

waynew99 commented 2 years ago

Working on fixing it...

ProfessorAmanda commented 2 years ago

Thanks, bud! Is this one issue that keeps arising during the deployment step, or something different each time? It would be great to have this solved so I can fix small things after we lose you on Friday.

Amanda G. Gregg Associate Professor of Economics, Middlebury College Join My Personal Zoom Roomhttps://middlebury.zoom.us/my/agregg?pwd=OWlGMmZMSWJaUkowRG5DUWJtRm9CQT09 (Password: EconHist) Office: Farrell House 101 Office Phone: (802) 443 - 3419 Pronouns: she/her/hers

From: Wayne Wang @.> Sent: Wednesday, August 10, 2022 4:26 PM To: ProfessorAmanda/econsimulations @.> Cc: Gregg, Amanda G. @.>; Author @.> Subject: Re: [ProfessorAmanda/econsimulations] Updating based on recent changes (PR #317)

Working on fixing it...

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FProfessorAmanda%2Feconsimulations%2Fpull%2F317%23issuecomment-1211230852&data=05%7C01%7Cagregg%40middlebury.edu%7C7f4a68fec97a49da3db708da7b0e9b9e%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C637957599915288366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=a5AVEZBAwa1OjgzMbmkLBk5aWc0%2FpQ4Suh%2B2RV1p0eY%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMWGM7FEJUBANPXDSHPCR4TVYQF7LANCNFSM56F274WA&data=05%7C01%7Cagregg%40middlebury.edu%7C7f4a68fec97a49da3db708da7b0e9b9e%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C637957599915288366%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=08WlbapMal8vg%2B8B6IrU%2FXdQd7zrvtjSOFz7npCLVxY%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

waynew99 commented 2 years ago

I think the issue is pretty stand-alone. It's an issue about tests not able to run with service worker added. I didn't find a quick fix to properly setup tests with service workers. For now, I'm skipping the tests on modules that involve service worker, so that we can deploy. I will keep investigating how to properly make tests work with Workers.

ProfessorAmanda commented 2 years ago

Cool!

Amanda G. Gregg Associate Professor of Economics, Middlebury College Join My Personal Zoom Roomhttps://middlebury.zoom.us/my/agregg?pwd=OWlGMmZMSWJaUkowRG5DUWJtRm9CQT09 (Password: EconHist) Office: Farrell House 101 Office Phone: (802) 443 - 3419 Pronouns: she/her/hers

From: Wayne Wang @.> Sent: Wednesday, August 10, 2022 4:54 PM To: ProfessorAmanda/econsimulations @.> Cc: Gregg, Amanda G. @.>; Author @.> Subject: Re: [ProfessorAmanda/econsimulations] Updating based on recent changes (PR #317)

I think the issue is pretty stand-alone. It's an issue about tests not able to run with service worker added. I didn't find a quick fix to properly setup tests with service workers. For now, I'm skipping the tests on modules that involve service worker, so that we can deploy. I will keep investigating how to properly make tests work with Workers.

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FProfessorAmanda%2Feconsimulations%2Fpull%2F317%23issuecomment-1211259884&data=05%7C01%7Cagregg%40middlebury.edu%7C4b03dc45761848e1f15d08da7b127566%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C637957616457814798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xcavYt0X06jvTEA2sn%2BpVP6%2FQJQguR7ZroY4fS4SMNo%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMWGM7AHOU6MZF7DZYJUGCLVYQJGVANCNFSM56F274WA&data=05%7C01%7Cagregg%40middlebury.edu%7C4b03dc45761848e1f15d08da7b127566%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C637957616457814798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YUaxyULLC%2BqptZMhUbrkL6ZngLrCo%2F3%2FeUdzrobRaNI%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

ProfessorAmanda commented 2 years ago

So everything seems to be working now. This is maybe a silly question but did you mention that you were going to update the icon I see in the Chrome tab for the page? I still see a black triangle. I feel like I probably misunderstood what you meant.

Amanda G. Gregg Associate Professor of Economics, Middlebury College Join My Personal Zoom Roomhttps://middlebury.zoom.us/my/agregg?pwd=OWlGMmZMSWJaUkowRG5DUWJtRm9CQT09 (Password: EconHist) Office: Farrell House 101 Office Phone: (802) 443 - 3419 Pronouns: she/her/hers

From: Gregg, Amanda G. @.> Sent: Wednesday, August 10, 2022 4:54 PM To: ProfessorAmanda/econsimulations @.> Subject: Re: [ProfessorAmanda/econsimulations] Updating based on recent changes (PR #317)

Cool!

Amanda G. Gregg Associate Professor of Economics, Middlebury College Join My Personal Zoom Roomhttps://middlebury.zoom.us/my/agregg?pwd=OWlGMmZMSWJaUkowRG5DUWJtRm9CQT09 (Password: EconHist) Office: Farrell House 101 Office Phone: (802) 443 - 3419 Pronouns: she/her/hers

From: Wayne Wang @.> Sent: Wednesday, August 10, 2022 4:54 PM To: ProfessorAmanda/econsimulations @.> Cc: Gregg, Amanda G. @.>; Author @.> Subject: Re: [ProfessorAmanda/econsimulations] Updating based on recent changes (PR #317)

I think the issue is pretty stand-alone. It's an issue about tests not able to run with service worker added. I didn't find a quick fix to properly setup tests with service workers. For now, I'm skipping the tests on modules that involve service worker, so that we can deploy. I will keep investigating how to properly make tests work with Workers.

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FProfessorAmanda%2Feconsimulations%2Fpull%2F317%23issuecomment-1211259884&data=05%7C01%7Cagregg%40middlebury.edu%7C4b03dc45761848e1f15d08da7b127566%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C637957616457814798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=xcavYt0X06jvTEA2sn%2BpVP6%2FQJQguR7ZroY4fS4SMNo%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMWGM7AHOU6MZF7DZYJUGCLVYQJGVANCNFSM56F274WA&data=05%7C01%7Cagregg%40middlebury.edu%7C4b03dc45761848e1f15d08da7b127566%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C637957616457814798%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=YUaxyULLC%2BqptZMhUbrkL6ZngLrCo%2F3%2FeUdzrobRaNI%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.***>

waynew99 commented 2 years ago

That's exactly what I intended to fix! The logo is showing up on my chrome. It is possibly be due to cached data in your browser. You can try holding down "Shift" and click the refersh button to force a full refresh.

ProfessorAmanda commented 2 years ago

Bingo! The full refresh worked. Cool!!

Amanda G. Gregg Associate Professor of Economics, Middlebury College Join My Personal Zoom Roomhttps://middlebury.zoom.us/my/agregg?pwd=OWlGMmZMSWJaUkowRG5DUWJtRm9CQT09 (Password: EconHist) Office: Farrell House 101 Office Phone: (802) 443 - 3419 Pronouns: she/her/hers

From: Wayne Wang @.> Sent: Wednesday, August 10, 2022 5:00 PM To: ProfessorAmanda/econsimulations @.> Cc: Gregg, Amanda G. @.>; State change @.> Subject: Re: [ProfessorAmanda/econsimulations] Updating based on recent changes (PR #317)

That's exactly what I intended to fix! The logo is showing up on my chrome. It is possibly be due to cached data in your browser. You can try holding down "Shift" and click the refersh button to force a full refresh.

— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FProfessorAmanda%2Feconsimulations%2Fpull%2F317%23issuecomment-1211265568&data=05%7C01%7Cagregg%40middlebury.edu%7Ca177b79bf12d4a4044b208da7b134da2%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C637957620080301023%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=LmrHGKY6PVGE3UcSAsQ5g%2FFKtrGVVm6LJLmgvd%2Bzq9o%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAMWGM7BFJ7SBAUVYZM77LRLVYQJ5NANCNFSM56F274WA&data=05%7C01%7Cagregg%40middlebury.edu%7Ca177b79bf12d4a4044b208da7b134da2%7Ca1bb0a191576421dbe93b3a7d4b6dcaa%7C1%7C0%7C637957620080301023%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=jw3VZVcDejV0ScjDMQcX5zML67yMO5KS%2FL8Lx0dksdI%3D&reserved=0. You are receiving this because you modified the open/close state.Message ID: @.***>