ProgerXP / Notepad2e

Word highlighting, simultaneous editing, split views, math evaluation, un/grep, comment reformatting, UAC elevation, complete regexps (PCRE), Lua lexers, DPI awareness and more (XP+)
Other
372 stars 52 forks source link

ScrollYCaretPolicy affecting some input commands but not others #294

Open ProgerXP opened 4 years ago

ProgerXP commented 4 years ago

Currently if you just type something (e.g. press q, w, etc.) ScrollYCaretPolicy is not used. If you delete something with Backspace or Del it's also not used. However, it's used with Ctrl+Backspace or Ctrl+Del.

This should be made consistent by either disabling ScrollYCaretPolicy for Ctrl+Backspace/Del or enabling it for other (normal) input commands.

Note: this does not happen with the previous released version (https://github.com/ProgerXP/Notepad2e/releases/tag/R92). I suspect it might be caused by #279 but I don't see how it's related.

cshnik commented 4 years ago

Fixed. ScrollYCaretPolicy is now applied in all cases: chars, (Ctrl+)Del/Backspace.

ProgerXP commented 9 months ago

Years after using ScrollYCaretPolicy of 1 (33%) I understood we should not adjust the scroll position in response to modification and near navigation (using arrows) because it's mildly annoying (always) and inconvenient (if just 10-20 lines are visible in a buffer or whole window - evenScrollYCaretPolicy of 0, which is 4 lines, doesn't help).

Let's revert changes done in this issue as well as check how simple it is to: