ProgerXP / Notepad2e

Word highlighting, simultaneous editing, split views, math evaluation, un/grep, comment reformatting, UAC elevation, complete regexps (PCRE), Lua lexers, DPI awareness and more (XP+)
Other
375 stars 52 forks source link

Do not clear Undo history on cancel Edit Mode #374

Closed ProgerXP closed 2 years ago

ProgerXP commented 3 years ago

Enter aa, space, Copy All (Alt+C), Paste twice, Undo (Ctrl+Z, another Undo is still possible), Ctrl+Tab, Escape (no more Undo even though no changes were made).

cshnik commented 3 years ago

Cannot Reproduce.

Enter aa, space, Copy All (Alt+C), Paste twice, Undo (Ctrl+Z, another Undo is still possible)

Gives the following:

aa aa |

Next step is:

Ctrl+Tab, Escape

Ctrl+Tab does not work on whitespace. If we move cursor back and repeat Ctrl+Tab, Escape:

aa |aa

Undo is available, however first undo action does not affect the documents text (while subsequent call does).

ProgerXP commented 3 years ago

Ctrl+Tab does not work on whitespace. If we move cursor back and repeat Ctrl+Tab, Escape:

Yes, that's what I mean.

Undo is available, however first undo action does not affect the documents text (while subsequent call does).

My bad, I meant "Redo", not "Undo". History is truncated in such a way that you no longer can Redo this step:

Undo (Ctrl+Z, another Undo is still possible)

https://user-images.githubusercontent.com/1643195/139312211-0c82a73a-06c0-4bb4-a600-15dc608c1e3e.mp4

cshnik commented 2 years ago

Fixed.