search

Program-AR / gs-element-blockly

Blockly element for gobstones web
GNU Lesser General Public License v3.0
1 stars 4 forks source link

Media not being found #100

Closed luchotc closed 6 years ago

luchotc commented 6 years ago

https://github.com/Program-AR/gs-element-blockly/blob/80dc10890eca6e3ee98505a0b2cbc996176eced9/gs-element-blockly.html#L211

This causes the path to be relative to the calling url and the media isn't found when using it in other projects

asanzo commented 6 years ago

Absolutely right. The path should be delivered as a parameter to the component. ( I edited your comment to point to the permalink of the line)

afska commented 6 years ago

Hmm, it's already a parameter :stuck_out_tongue: (media), and "../bower_components/blockly-package/media/" is just a default value.

afska commented 6 years ago

I fixed the problem in mumuki-gobstones-runner using:

<gs-element-blockly media="https://github.com/Program-AR/blockly-package/raw/v0.0.15/media/"></gs-element-blockly>

so the media parameter is working. Closing!