search

Programmer245 / IS24-AM32

Software Engineering Project - Bachelor of Computer Engineering (PoliMi)
0 stars 0 forks source link

availableSpace bug? #105

Closed lorenzo-cmyk closed 4 months ago

lorenzo-cmyk commented 4 months ago

IMG_20240528_192552_913.jpg

IMG_20240528_192555_595.jpg

AvailableSpace is not reporting spaces correctly? The method should be already tested

lorenzo-cmyk commented 4 months ago

Bug confirmed. availableSpace in Field class is build under the assumption that all cards are fully coverable in the back but that is not true for starting cards

ingconti commented 4 months ago

pls follow good practice: 1) isolate problem 2) cut code in small methods 3) test singular modules You cut down with various test

lorenzo-cmyk commented 4 months ago

Actually the fix is like 6 LOC long. I'm writing some tests for covering the edge cases but it should be fixed.

The real "problem" is that I need to merge some branches because they are kind of exploding in number right now

lorenzo-cmyk commented 4 months ago

Should be fixed