search

ProgrammingLife2016 / PL2-2016

Visualization tool for exploratory data analysis of DNA sequences
Apache License 2.0
3 stars 0 forks source link

Annotation bugfix and extra heatmap #253

Closed FarisElghlan closed 8 years ago

FarisElghlan commented 8 years ago

Fixed some small bugs before the presentation

justinvdk commented 8 years ago

I agree with those changes. Seen the bugs firsthand and think they should be included. NOTE: also adds an extra heatmap option for the graph, which technically is a new feature. (hence the gui tag)

Pathemeous commented 8 years ago

I don't want to become nazi again, but I kinda do.

Could you separate your commits to reflect the bug fixes. Also ahve a commit message that explains what was wrong (why was the change necessary and why the way you implemented it)

Otherwise I'm sure your code is correct.

Pathemeous commented 8 years ago

Please do this since I want to merge your code

Pathemeous commented 8 years ago

Thanks, merging

FarisElghlan commented 8 years ago

...

FarisElghlan commented 8 years ago

?

Pathemeous commented 8 years ago

Sorry, waiting for checks but then had to travel.