search

ProgressNS / code-samples

Find code samples and building blocks for your NativeScript app in the Marketplace
https://market.nativescript.org/?tab=samples&framework=core&category=all_samples
Apache License 2.0
36 stars 22 forks source link

Personal Finance needs core #84

Open rdlauer opened 5 years ago

rdlauer commented 5 years ago

Be sure you are basing any new framework versions on the latest iteration of this app! You can find the latest version in data/all.json or on the marketplace website.

https://play.nativescript.org/?template=play-vue&id=4JhSZz&v=49

tylerablake commented 5 years ago

I'm working on adding angular to this sample.

tylerablake commented 5 years ago

Here's the angular addition: https://play.nativescript.org/?template=play-ng&id=zYpU71&v=8

Let me know if you see any issues.

The 3rd tab was not working on the sample so I tried to match what I thought the sample was trying to do. I'll open a different issue for that though.

rdlauer commented 5 years ago

Looks good! I did see one error show up on Android:

[Moto G (5) Plus]: Error in reading bitmap - java.io.FileNotFoundException: /data/data/org.nativescript.preview/files/app/images/yellow (No such file or directory)

Any ideas why the taps are so sluggish to navigate between the views?

tylerablake commented 5 years ago

Oh, oops, I left my Android test device at the office so I can fix that Android error on Monday.

Is it only sluggish on Android or do you notice it on iOS as well? If you are noticing it on iOS as well I can look at it tomorrow.

rdlauer commented 5 years ago

Yeah it seemed pretty slow on iOS as well - at least taps on the tabs aren't registering quickly? Strange.

tylerablake commented 5 years ago

Ok I'll look at it.

tylerablake commented 5 years ago

https://play.nativescript.org/?template=play-ng&id=zYpU71&v=9

Try this and let me know if it is better on your end. I didn't really notice any lag but I made the tap area a little bigger so hopefully that'll fix it for you.

rdlauer commented 5 years ago

I think that was it, thanks!

tylerablake commented 5 years ago

Perfect, I'll look into that Android issue tomorrow and post an updated link for that.

tylerablake commented 5 years ago

Here's the updated link: https://play.nativescript.org/?template=play-ng&id=zYpU71&v=10

I noticed the tab images were pretty small on Android so I addressed that as well.