search

ProgressNS / nativescript-ui-feedback

This repository is used for customer feedback regarding Telerik UI for NativeScript. The issues system here is used by customers who want to submit their feature requests or vote for existing ones.
Other
115 stars 21 forks source link

RadListView crashes on rotate orientation, on iOS, Vue (when using item layout Grid or Staggered) #1056

Closed tralves closed 5 years ago

tralves commented 5 years ago

Please, provide the details below:

Tell us about the problem

Using a RadListView with layout="grid", on a NS-Vue project, on iOS, the app crashes when changing orientation.

Which platform(s) does your issue occur on?

iOS. I only tested on the simulator, though.

Please provide the following version numbers that your issue occurs with:

Please tell us how to recreate the issue in as much detail as possible.

I created a project with the simplest example possible here.

  1. Start the app on iOS (tns run ios --bundle).
  2. Rotate the device or simulator.

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

I tested with the code from the documentation:

      <RadListView for="item in itemList"
                   layout="grid"
                   itemHeight="100">
        <v-template>
          <StackLayout orientation="vertical">
            <Label :text="item.name"></Label>
          </StackLayout>
        </v-template>
      </RadListView>
NickIliev commented 5 years ago

Confirming this one as a bug - the issue is appearing when using item layout of type grid or of type staggered.

Removing the item layout property is resolving the case.

aggalix commented 5 years ago

It's not just on Vue projects. I'm experiencing this on a vanilla NS Typescript project too.

dottodot commented 5 years ago

Same is happening for Angular as well. Any ideas on when this will be fixed?

dottodot commented 5 years ago

Actually seems to be ok in the latest release which is a bit odd considering the issue hasn't be addressed.

tralves commented 5 years ago

I just tested both on my project and the test project and it still crashes.

I updated the ns-ui-listview to 6.2.0.

dottodot commented 5 years ago

@tralves You are right, however I do have one view that isn't crashing, the only difference I can see is it doesn't have any images in it.

tralves commented 5 years ago

My sample app doesn't have images either... can you show me your sample that doesn't crash?

dottodot commented 5 years ago

@tralves 

<GridLayout class="page">
  <RadListView class="m-5" [items]="projects$ | async" backgroundColor="transparent"
    (itemLoading)="makeBackgroundTransparent($event)">
    <ng-template tkListItemTemplate let-project="item">
      <StackLayout appCard class="m-5" (tap)="select(project.id)">
        <GridLayout class="list-group-item" rows="*,*,*" columns="auto, *" card-body>
          <Label class="h3" row="0" col="1" [text]="project.title"></Label>
          <Label class="text-uppercase h6" row="1" col="1" [text]="project.site_code"></Label>
          <Label class="text-uppercase h6" row="2" col="1" [text]="project.project_type"></Label>
        </GridLayout>
      </StackLayout>
    </ng-template>
    <ListViewStaggeredLayout tkListViewLayout scrollDirection="Vertical" spanCount="4">
    </ListViewStaggeredLayout>
  </RadListView>
</GridLayout>
matecode commented 5 years ago

Anyone handling this bug? It's preventing our project from being updated to current plugin version.

YaakovDavid commented 5 years ago

Same issue, with ListViewGridLayout and ListViewStaggeredLayout that the app crashes on rotation this is both on the simulator and running on any iOS device (through TestFlight). I do have images in the GridLayout but even when I comment it out it still crashes. I am using NativeScript core with Typescript. Any fix/ workaround will be extremely helpful.

silviosan commented 5 years ago

Are there any news regarding this severe bug? Any information if and when this will be fixed is really appreciated.

VladimirAmiorkov commented 5 years ago

Hi,

We are currently investigating the source of this issue and hope to have a patch fix as soon as possible.

fhackenb commented 5 years ago

I've been seeing an error in sentry sporadically for a couple months now: 

EXC_BAD_ACCESS: Exception 1, Code 1863350352, Subcode 8 >
Stack overflow in (null)
  ?, in CFBasicHashCreateCopy
  ?, in CFDictionaryCreateMutableCopy
  ?, in -[_CFXNotificationNameWildcardObjectRegistration find:matching:]
  ?, in -[_CFXNotificationRegistrar find:object:observer:enumerator:]
  ?, in _CFXNotificationPost
...
(95 additional frame(s) were not displayed)

Just recently realized it was tied to this orientation change issue. Glad to hear a fix is on the way

zbranzov commented 5 years ago

The fix is released in nativescript-ui-listview@6.4.2

YaakovDavid commented 5 years ago

It seems to work, Thank you @VladimirAmiorkov @zbranzov

YaakovDavid commented 5 years ago

It works great with nativescript-ui-listview@6.4.2 but I just upgraded to NativeScript 6.0 with npm install -g nativescript@rc and it changed the list view to "nativescript-ui-listview": "7.0.0-androidx-110619", in my package.json which broke the listview on rotation again. Can you move the fix the Nativescript 6.0 as well please.

VladimirAmiorkov commented 5 years ago

Hi @YaakovDavid ,

We are in the process of updating the 7.0.0-androidx tag with our latest official fixes so stay tuned.