search

ProgressNS / nativescript-ui-feedback

This repository is used for customer feedback regarding Telerik UI for NativeScript. The issues system here is used by customers who want to submit their feature requests or vote for existing ones.
Other
115 stars 21 forks source link

[RadListView] Swipe actions not working as expected #1340

Closed quinnban closed 4 years ago

quinnban commented 4 years ago

Please take a minute to read our NativeScript Code of Conduct before proceeding with posting issues or discussing. The purpose of this guide is to make communication and cooperation within our forums a pleasure for you and the other members.

Please, provide the details below:

Tell us about the problem

When following the instructions on the website the swipe events do not work was expected.

  1. On Android the "itemSwipeProgressEnded" event will always return 0 for the 'data.x'
  2. On IOS the swipe does not map '1-1' with the users finger.
  3. On IOS the swipe limits seem to not matter, the user can swipe either was regardless of if the swipe limit was set to 0.

Which platform(s) does your issue occur on?

Both

Please provide the following version numbers that your issue occurs with:

tns --version 6.2.0 "tns-android": { "version": "6.2.0" }, "tns-ios": { "version": "6.2.0" } "nativescript-ui-listview": "^8.0.1", "tns-core-modules": "6.3.2",

Please tell us how to recreate the issue in as much detail as possible.

I have created a playground where you can see the android issue. But I don't have a physical IOS phone so I am unsure if you will be able to see the IOS issues on the playground.

  1. run playground
  2. swipe item
  3. look at console

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

Here is a playground example that I was able to see the issue. https://play.nativescript.org/?template=play-ng&id=OiVkmk

quinnban commented 4 years ago

I removed and readded my ios platform and it seems to fix the problem. The android problem still remains.

quinnban commented 4 years ago

I figured out the issue, in the "ui-listview.android.js" file the "ListViewSwipeActionsListenerImpl.prototype.onSwipeEnded"(line 716) function is not filled out but the "ListViewSwipeActionsListenerImpl.prototype.onExecuteFinished"(line 743 on mine) is. Copy and paste the code from the ladder function to the first and it will work as intended.