ProgressNS / nativescript-ui-feedback

This repository is used for customer feedback regarding Telerik UI for NativeScript. The issues system here is used by customers who want to submit their feature requests or vote for existing ones.
Other
115 stars 21 forks source link

I cannot see the label on Android with RadLegendView (Dark Mode) #1386

Open sanghyun5958 opened 4 years ago

sanghyun5958 commented 4 years ago

Please take a minute to read our NativeScript Code of Conduct before proceeding with posting issues or discussing. The purpose of this guide is to make communication and cooperation within our forums a pleasure for you and the other members.

Please, provide the details below:

Tell us about the problem

Please, ensure your title is less than 63 characters long and starts with a capital letter.

Which platform(s) does your issue occur on?

iOS/Android/Both (if applicable tell us the specific version of the platform)

Please provide the following version numbers that your issue occurs with:

Please tell us how to recreate the issue in as much detail as possible.

  1. Start the application ..
  2. ...

Is there code involved? If so, please share the minimal amount of code needed to recreate the problem.

(You can paste entire code snippets, link to playground demo or attach a runnable project)

NickIliev commented 4 years ago

@sanghyunj5958 is this happening on Android or on iOS (or both)?

Have you tried to use the dark mode CSS classes to style the legend and to use the titleColor property?

The best approach would be to provide a test demo (e.g., a Playground) that demonstrates your usage.

KevIvers commented 3 years ago

I have come across this issue on version 7.1.1 (android). Steps to repro would be the phone in dark mode, but the app is set to theme light: main.ts -> Theme.setMode(Theme.Light); which overrides the systems dark mode settings.

The bug appears to be here, in that its only checking the systemAppearance, when choosing the legend color and should cross check with the theme also RadLegendView.prototype.getColorForCurrentTheme = function () { if (applicationModule.systemAppearance() === enums_1.SystemAppearance.dark) { return new color_1.Color("white"); } else { return new color_1.Color("#6a6a6a"); } };

I haven't got a chance to test the latest version(8.02), but code looks to have similar issue getColorForCurrentTheme() { if (Application.systemAppearance() === Enums.SystemAppearance.dark) { return new Color("white"); } else { return new Color("#6a6a6a"); } }