search

ProgressNS / nativescript-ui-feedback

This repository is used for customer feedback regarding Telerik UI for NativeScript. The issues system here is used by customers who want to submit their feature requests or vote for existing ones.
Other
115 stars 21 forks source link

NativeScript 7 Upgrade Build Fails #1488

Open ShawnPavel opened 3 years ago

ShawnPavel commented 3 years ago

Tell us about the problem

After upgrading to NativeScript 7 I'm running into a buidl error that appears to pertain to the nativescript-ui-listview plugin. There's a few errors in the console when running ns build ios

node_modules/nativescript-ui-listview/references.d.ts:1:22 - error TS6053: File 'mobile/node_modules/nativescript-ui-listview/node_modules/@nativescript/core/global-types.d.ts' not found.

1 /// <reference path="./node_modules/@nativescript/core/global-types.d.ts" />
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/nativescript-ui-listview/references.d.ts:2:22 - error TS6053: File 'mobile/node_modules/nativescript-ui-listview/node_modules/@nativescript/types/index.d.ts' not found.

2 /// <reference path="./node_modules/@nativescript/types/index.d.ts" />
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/nativescript-ui-listview/references.d.ts:3:22 - error TS6053: File 'mobile/node_modules/nativescript-ui-listview/node_modules/nativescript-ui-core/ios.d.ts' not found.

3 /// <reference path="./node_modules/nativescript-ui-core/ios.d.ts" />
                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
node_modules/nativescript-ui-listview/references.d.ts:4:22 - error TS6053: File '/mobile/node_modules/nativescript-ui-listview/node_modules/nativescript-ui-core/android.d.ts' not found.

4 /// <reference path="./node_modules/nativescript-ui-core/android.d.ts" />

Which platform(s) does your issue occur on?

Android and iOS

Please provide the following version numbers that your issue occurs with:

ShawnPavel commented 3 years ago

I was able to resolve this simply by removing those type references from the references.d.ts within the node_modules folder. But that's obviously less than ideal to have to do every time I do npm i

jessorlisa commented 3 years ago

Do you have @nativescript/types in your devDependencies?

If not try: npm install @nativescript/types --save-dev.

frunjik commented 3 years ago

FWIW

This prevents me from updating nativescript-ui-sidedrawer 9.0.3

I think its part of some bigger problem with import type references (somewhere) ... (I remember having patched other files before)

frunjik commented 3 years ago

(And yes I have @nativescript/types in my devDependencies)

"@nativescript/types": "^7.0.4",

rmn81 commented 3 years ago

Trying adding "skipLibCheck": true in tsconfig