search

ProgressNS / sidekick-feedback

This repository is for feedback regarding NativeScript Sidekick. Use the issues system here to submit feature requests or vote for existing ones.
45 stars 9 forks source link

Android deploys icons not shown in Sidekick #253

Open yoat opened 6 years ago

yoat commented 6 years ago

Please, provide the details below:

Did you verify whether this issue has already been reported here?

Yes

Tell us about the problem

I imported assets (1024x1024) for the Icon. Sidekick processed them for iOS and Android. Inside Sidekick all the icons (for iOS and Android) are shown with rounded corners. When I deployed the app (in Debug mode) to the Android device the icon used is a fully square image - the corners are not rounded off. I uninstalled the previous version of the app to ensure there was no conflict. All builds are local.

Which platform(s) does the issue occur on?

When deploying (as Release build) on iOS the icons have rounded corners. On Android the "original" square image is used as the icon.

Provide the following version numbers that the issue occurs with:

Tell us how to recreate the issue in as much detail as possible

  1. Generate new project.
  2. Note that Sidekick shows the default NativeScript (blueprint style) icon with rounded corners.
  3. Deploy the app to device.
  4. Observe that the deployed icon has square edges. X. Alternatively, try it with a new custom icon.

Does this issue happen every time?

Yes

Send the client logs

No logs - this issue exists within Sidekick before build or deploy time.

Workaround

I can manually round the edges off the image and rely on Sidekick only to manage resizing the assets and this should be fine.

Suggestion

The current style for Android icons is full circles. It was my initial assumption from this article that Sidekick would generate circles instead of rounding the corners, but the Sidekick app displays rounded corners. It would be great to choose between rounded corners and full circle, but I'm not formally suggesting that yet.

ggarabedian commented 6 years ago

Hello @yoat,

The rounded edges in the visualization of the Android icons in Sidekick is purely cosmetic, but I see how it can be confusing, especially considering the initial circular image. The idea of the asset generation service is to resize a single image so that it works for all iOS and Android device. Nevertheless, your suggestion sounds like a good addition to the already available functionality. With this in mind, I have forwarded the suggestion to our development team for further consideration.

In the meantime, the only workaround is the one that you have already mentioned - manually generate a circular or rounded corners icon and use Sidekick only to resize it.

yoat commented 6 years ago

Thanks for the clarification!