ProgressNS / sidekick-feedback

This repository is for feedback regarding NativeScript Sidekick. Use the issues system here to submit feature requests or vote for existing ones.
45 stars 9 forks source link

Font assets not included in Sidekick cloud build #280

Closed lachlanwp closed 6 years ago

lachlanwp commented 6 years ago

Please, provide the details below:

Did you verify whether this issue has already been reported here?

Yes

Tell us about the problem

Fonts aren't being bundled in Cloud build resulting in broken fonts. I'm try to use icon fonts for icons in my app. Method I've used is proven to work using the playground.

Which platform(s) does the issue occur on?

Both using Windows PC

Provide the following version numbers that the issue occurs with:

N/a

Tell us how to recreate the issue in as much detail as possible

  1. Follow guide from blog post https://www.nativescript.org/blog/using-custom-fonts-in-a-nativescript-app

Does this issue happen every time?

Yes

Send the client logs

[18-10-10 20:27:10.804] (CLI) Asset Size Chunks Chunk Names [18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xhdpi/icon.png 2.81 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) bundle.js 126 KiB bundle [emitted] bundle [18-10-10 20:27:10.804] (CLI) App_Resources/Android/app.gradle 712 bytes [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/settings.gradle 1.63 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/settings.json 82 bytes [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/AndroidManifest.xml 1.42 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-hdpi/background.png 3 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-hdpi/icon.png 2.09 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-hdpi/logo.png 11.8 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-ldpi/background.png 1.13 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-ldpi/icon.png 1.08 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-ldpi/logo.png 3.73 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-mdpi/background.png 1.66 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-mdpi/icon.png 1.39 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-mdpi/logo.png 6.28 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-nodpi/splash_screen.xml 304 bytes [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xhdpi/background.png 4.72 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) vendor.js 5.44 MiB vendor [emitted] vendor [18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xhdpi/logo.png 18.5 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xxhdpi/background.png 9.3 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xxhdpi/icon.png 4.25 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xxhdpi/logo.png 25.7 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xxxhdpi/background.png 15.4 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xxxhdpi/icon.png 11.1 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/drawable-xxxhdpi/logo.png 25.7 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/values-v21/colors.xml 104 bytes [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/values-v21/styles.xml 898 bytes [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/values/colors.xml 237 bytes [emitted]
[18-10-10 20:27:10.804] (CLI) App_Resources/Android/src/main/res/values/styles.xml 1.68 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) app/images/logo.png 11.8 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) images/favicon-16x16.png 1.18 KiB [emitted]
[18-10-10 20:27:10.804] (CLI) package.json 82 bytes [emitted]
[18-10-10 20:27:10.804] (CLI) starter.js 39 bytes [emitted]
[18-10-10 20:27:10.804] (CLI) tns-java-classes.js 0 bytes [emitted]

ggarabedian commented 6 years ago

Hello @lachlanwp,

I tested a couple of apps (vanilla JS and Angular) with the Roboto and Varela fonts, and they are added correctly to the webpack bundle. I have placed the fonts in the <app-name>/app/fonts folder as suggested in the blog post that you have linked.

Having said that, can you give me more information so I can investigate this further: 1) Have you created your app in Sidekick or you have exported it from the Playground and then opened it in Sidekick? 2) What version of the nativescript-dev-webpack plugin you have included in your app? 3) Which icon font are you trying to add to your app?

ggarabedian commented 6 years ago

Closing the issue due to inactivity. Please, consider opening a new issue if you continue to experience the problem with the latest version of NativeScript Sidekick.