search

Progressive-Learning-Platform / PLPTool6

Prototype for PLPTool frontend interface overhaul
2 stars 4 forks source link

Refactor tushar #99

Open tusharpandit18 opened 6 years ago

tusharpandit18 commented 6 years ago

Updated documentation with JavaDoc formatting

tobielf commented 6 years ago

OK, I thought you finished your changes. Keep updating on your current branch and p/r. You don’t need to create a new one.

On Fri, Sep 29, 2017 at 1:37 AM Tushar Pandit notifications@github.com wrote:

@tusharpandit18 commented on this pull request.

In src/main/java/edu/asu/plp/tool/backend/isa/events/RegWatchResponseEvent.java https://github.com/Progressive-Learning-Platform/PLPTool6/pull/99#discussion_r141816346 :

private LongProperty regObject;
  • /**
    • @brief This is a constructor for which accepts Success, ErrorMessage, ProjectName and ASMImage parameters

Was replicating Java Doc syntax. Mistakenly forgot to remove the comment. Will rectify and issue a new pull request.

— You are receiving this because your review was requested.

Reply to this email directly, view it on GitHub https://github.com/Progressive-Learning-Platform/PLPTool6/pull/99#discussion_r141816346, or mute the thread https://github.com/notifications/unsubscribe-auth/ACkWj-bPagR9aFdfOpmpzDqFK9utCCtmks5snKxAgaJpZM4PiBc8 .

tusharpandit18 commented 6 years ago

Modified few comments

tobielf commented 6 years ago

Let me know when you finished the changes. Are you still working on your branch?

tusharpandit18 commented 6 years ago

I am done