ProgressiveCoders / progcode-website

https://progcode.org
10 stars 6 forks source link

Use brand identity colors #20

Closed baisong closed 6 years ago

baisong commented 6 years ago

Changes related to #18:

Before

1 of 4 screenshot from 2018-07-28 20-29-43

2 of 4 screenshot from 2018-07-28 20-29-55

3 of 4 screenshot from 2018-07-28 20-30-07

4 of 4 screenshot from 2018-07-28 20-30-19

After

1 of 4 screenshot from 2018-07-28 20-24-34

2 of 4 screenshot from 2018-07-28 20-24-47

3 of 4 screenshot from 2018-07-28 20-25-05

4 of 4 screenshot from 2018-07-28 20-25-18

baisong commented 6 years ago

P.S. I tried using the Brand Yellow (#ffea00) as a background, but it seemed very harsh, that's why I replaced the two yellow zones with white.

An alternative might be to create brand pastel variants of all eight colors, and use those?

screenshot from 2018-07-28 20-35-35 screenshot from 2018-07-28 20-36-01

baisong commented 6 years ago

Good call. From the brand guide, white text on the purple color only passed 3 of the 4 tests. I updated the PR to have a slightly darker purple, which passes all four tests.

baisong commented 6 years ago

Here's the color contrast checker results for the proposed sections, based on Web Content Accessibility Guidelines (WCAG) 2.0:

baisong commented 6 years ago

Or, alternatively, we could close this PR without merging, and go with this updated pastel pallette:

https://github.com/ProgressiveCoders/progcode-website/pull/22

stephenscapelliti commented 6 years ago

Oren, are the 4 tests for matching to the brand guidelines?

baisong commented 6 years ago

Hi @stephenscapelliti, no they were for visual accessibility (color contrast tests).

However, I misunderstood the task, and moved my work over into the Pastel update (#22).

Closing this PR in favor of #22