Progresst-8 / pe

0 stars 0 forks source link

Duplicate Entries in list #11

Open Progresst-8 opened 2 weeks ago

Progresst-8 commented 2 weeks ago

image.png I can make the recipes have duplicate entries by having duplicate entries in the save file. Similarly for the ingredients.

nus-pe-script commented 2 weeks ago

Team's Response

This issue is similar to #118.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Possible to create duplicate recipe names by editing cookbook.txt

When manually editing the saved data in the database, it is possible to get the program to have duplicate recipe names as shown below.

However, the program does not usually allow duplicate recipe names, as seen from the error message when another recipe named "n6" is being added from the program itself.

image.png

This is an inconsistency in the program logic, given that the documentation states that being able to manually edit the .txt file database is allowed:

image.png

This can lead to issues with commands that rely on recipe names being unique, such as 'delete' as shown below.

image.png

This can lead to possible undefined behavior as the program flow has been disrupted, since duplicate entries are not usually intended.


[original: nus-cs2113-AY2425S1/pe-interim#224] [original labels: severity.Low type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Dear Tester,

We agree that this is a bug in the storage system on our end. Your issue has been accepted as is. Thank you.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]