search

Project-Bonfire / Bonfire_legacy

A Fault Tolerant NoC Architecture
GNU General Public License v3.0
7 stars 8 forks source link

Remove trailing whitespace #14

Closed AlexDaniel closed 6 years ago

AlexDaniel commented 7 years ago

As uncritical as it is, but there is definitely a limit of how much trailing whitespace can be tolerated.

I tried not to touch files where trailing whitespace could make a difference (or makes no difference whatsoever). Brave souls are encouraged to review the diff.

A more crucial thing would be to have no mixed identation (in this particular case tabs have to be replaced with spaces). This is especially important in .py files, and I'm even surprised that things are working correctly right now. A simple approach of changing all tabs to 4 spaces is not going to work given that some cases will have to be dealt with manually… but that's too much of work for what it's worth, at least until issue #12 is resolved.

As a (positive) side effect of stripping out trailing whitespace, in a couple of files CR-LF line endings were changed to LF.

AlexDaniel commented 7 years ago

Note that there may be some good (but sad) reasons not to merge this. I thought I'd give it a go in case you're interested.

AlexDaniel commented 6 years ago

This was an interesting attempt given the scale of it 😆 There are now many conflicts so it's not going to be merged as is, and there was never an extreme need for this anyway. Therefore I'll close it for now.