Sending fake mail - Githubissues

gabrielronei commented 2 years ago

Summary of change

I've added @Profile for the implementations of EmailService and called interface on Controller and let spring inject which implementation is available depending on the current profile.

This helps us to remove the if(environment...)

Additional context

Request
On console

Related issue

Closes #891

Pull request checklist

Please keep this checklist in & ensure you have done the following:

[x] Read, understood and adhered to our contributing document.
- [x] Ensure that you were first assigned to a relevant issue before creating this pull request
- [x] Ensure code changes pass all tests
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

gabrielronei commented 2 years ago

Thanks for working on this.

I've left some preliminary comments for you to address. Could you also please fix the failing tests (the build is failing)?

i've fixed one test that was broken