Project-Books / book-project

Book tracker web app for book lovers
https://project-books.github.io/
GNU General Public License v3.0
482 stars 457 forks source link

Make Book to UserCreatedShelf relationship many-to-many #905

Closed knjk04 closed 2 years ago

knjk04 commented 2 years ago

Describe the solution you'd like Make the Book to UserCreatedShelf relationship many-to-many.

You should also ensure that the fetch type is still lazy and we avoid lazy initialisation exceptions.

Additional context

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

brunbs commented 2 years ago

Hi, I'd like to help with this if you still want. But I need some directions: should I fork it first then find a solution and then discuss the implementation? Or do I discuss the implementation first, get assigned to and just then fork the project?

knjk04 commented 2 years ago

Hi @brunbs, thanks for offering to help with this.

Either is fine, but I'd recommend the former:

fork it first then find a solution and then discuss the implementation?

The purpose of this is so that we can discuss early on whether that's the best approach (and perhaps alternative approaches that may be better) before you go off and actually implement the solution to save you time (and in case your solution is not what we were looking for).

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.