Project-Books / book-project

Book tracker web app for book lovers
https://project-books.github.io/
GNU General Public License v3.0
482 stars 457 forks source link

Create endpoint to check if email exists #925

Closed knjk04 closed 2 years ago

knjk04 commented 2 years ago

Is your feature request related to a problem? If so, please describe. When we log in on the frontend, we ask for the email and password together. If we ask for them separately, we can provide a nicer user experience by letting the user know which (out of email and password) field they typed in was incorrect

Describe the solution you'd like Create an endpoint in the UserController that uses our service method to see whether the email exists.

If the email does not exist, we should return a 404. If the email does exist, we can return 200 OK. This should be a GET method.

Additional context

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

kuruvasatya commented 2 years ago

Hi @knjk04, I would love to work on this! please assign this issue to me to start working on it. Thanks in advance

knjk04 commented 2 years ago

Hi @kuruvasatya, thanks!

kuruvasatya commented 2 years ago

hey @knjk04, Thanks for assigning this to me, I hope I have completed the task, I raised a PR, please review it and let me know if any thing else is needed/changed.