Project-Books / book-project

Book tracker web app for book lovers
https://project-books.github.io/
GNU General Public License v3.0
482 stars 457 forks source link

Move model package inside book package #927

Closed knjk04 closed 2 years ago

knjk04 commented 2 years ago

Describe the solution you'd like Move our model package inside the book package.

You may encounter a query syntax exception (see https://gist.github.com/knjk04/f7f4c6b875eb2ef10e4bd7cadd20aa8b).

Additional context

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

TaeyeonRoyce commented 2 years ago

Hi, I'm a student who studies programming(Java, Spring). I'm recently finding open source to contribute and I want to do about this issue. I might be insufficient to solve this issue, but I want to fork this project and analyze codes to try it. I already read contribution docs. Please let me try this issue.

knjk04 commented 2 years ago

Hi @TaeyeonRoyce, thanks for offering to help out with this. I'll assign you to it. If you need a hand, please don't hesitate to reach out by creating a GitHub Q&A discussion or on our Slack workspace

TaeyeonRoyce commented 2 years ago

Hi @knjk04, I solved this issue (move model package inside book package) and I'd like to say about how I solved this. First, move model package inside book package. As you noticed, it causes "com.karankumar.bookproject.model.PredefinedShelfName.READ". So I fixed JPA query where in method "findReadShelf2" which approaches to PredefinedShelfName.

After work, I run all test and passed except for the test that failed in the main branch. (ReadingGoalControllerIntegrationTest)

As you know, all classes that imported model package have been changed. I also bring back some setting files such as "application-dev.properties" and "docker-compose.yml".

Please check my PR and let me know if I missed or did wrong. Thank you for assigned me.