Closed knjk04 closed 2 years ago
Hey @knjk04, I would like to take care of this issue.
I've already read the contributing guidelines.
My approach would be to install pre-commit and add a '.pre-commit-config.yaml' to the frontend. Configure the yaml files so it matches the style guide.
An estimate on how long I would need is Monday the 14th
Hi @barnes-c, thanks for offering to help with this! I'll assign it to you
Hi @barnes-c, how are you getting on with this?
Hi @barnes-c, as we have not heard back from you, we will unassign you (as per our contributing guidelines)
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
Is your feature request related to a problem? If so, please describe. Not running eslint before pushing can lead to a failed linter build.
Describe the solution you'd like Set up a pre-commit hook so that it triggers eslint to run whenever we try to commit one of the frontend files (
.ts
,.js
, etc.).See https://github.com/pre-commit/mirrors-eslint
Additional context
main
and setmain
as the destination branch in your pull requestIf you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace