Project-Books / book-project

Book tracker web app for book lovers
https://project-books.github.io/
GNU General Public License v3.0
482 stars 456 forks source link

Show GraphQL "loading" and "error Failed to fetch" messages on Search page #969

Closed RivaD2 closed 2 years ago

RivaD2 commented 2 years ago

Currently, if the Books-API is down/not running and a user types in a search query and clicks search, the return statements are executed for loading and error variables from GraphQL in Search.tsx. The loading text is shown, and then the following error message is shown on blank white page:

Screen Shot 2022-03-19 at 11 01 06 AM

What should happen/expected behavior:

If the Books-API is down/not running, the loading text and error message should be shown on Search.tsx below the search input, not on a separate page.

This issue is linked to: Search-Results-882

Additional context

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.