Project-Books / book-project

Book tracker web app for book lovers
https://project-books.github.io/
GNU General Public License v3.0
482 stars 456 forks source link

Feature: testcontainer support for integration tests #970

Closed anugrahsinghal closed 2 years ago

anugrahsinghal commented 2 years ago

Summary of change

Adds Testcontainer support for integration tests

Related issue

Closes #917

Pull request checklist

Please keep this checklist in & ensure you have done the following:

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

knjk04 commented 2 years ago

@anugrahsinghal Thanks for working on this! It looks like the conflicts are related to indentation.

Could you please run the google-java-format plugin (available for IntelliJ, Eclipse, etc.) on the files you have modified?

anugrahsinghal commented 2 years ago

hey @knjk04, applied the formatting.

sonarcloud[bot] commented 2 years ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

knjk04 commented 2 years ago

Hi @anugrahsinghal, thanks for fixing this & apologies for the delay. Something has come up at home, but I'll review this soon

anugrahsinghal commented 2 years ago

hey @knjk04, thanks for letting me know. Hope all is well :) The PR is going nowhere, take care :)

stale[bot] commented 2 years ago

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.