Project-Books / books-api

GraphQL Books API
https://project-books.github.io/#books-api
MIT License
35 stars 60 forks source link

Add Literary Awards won #108

Closed swetharnaik closed 3 years ago

swetharnaik commented 3 years ago

Summary of change

Created a Award Entity which maps to Book having ManytoMany to relationship. Added an Enum class, Updated SQL Script, Updated GraphQL Schema, Added test data

Related issue

Closes #15

Pull request checklist

Please keep this checklist in & ensure you have done the following:

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

swetharnaik commented 3 years ago

@knjk04 Example of the GraphQL findByAwardName query-

image

knjk04 commented 3 years ago

Thanks for working on this.

Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123

I noticed that your branch name is main. Would it be possible to create a branch off this (or rename) to something concise and descriptive that includes the issue number (e.g. 'literary-awards-15')? You'll need to create a new PR as this one will be invalid

swetharnaik commented 3 years ago

@knjk04 Sure