Closed swetharnaik closed 3 years ago
@knjk04 Example of the GraphQL findByAwardName query-
Thanks for working on this.
Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123
I noticed that your branch name is main. Would it be possible to create a branch off this (or rename) to something concise and descriptive that includes the issue number (e.g. 'literary-awards-15')? You'll need to create a new PR as this one will be invalid
@knjk04 Sure
Summary of change
Created a Award Entity which maps to Book having ManytoMany to relationship. Added an Enum class, Updated SQL Script, Updated GraphQL Schema, Added test data
Related issue
Closes #15
Pull request checklist
Please keep this checklist in & ensure you have done the following:
[x] Read, understood and adhered to our contributing document.
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[ ] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g.
test-reading-goal-123
[x] Set this pull request to 'draft' if you are still working on it
[ ] Resolved any merge conflicts
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub