Literary award 15

[swetharnaik]

Summary of change

Created an Award Entity which maps to Book having ManytoMany relationship. Added an Enum class, Updated SQL Script, Updated GraphQL Schema, Added test data. GraphQL Query Example- query { findByAwardName(awardName:"Nobel Prize in Literature") { title genre isbn13 yearOfPublication format } }

Related issue

Closes #15

Pull request checklist

Please keep this checklist in & ensure you have done the following:

• [x] Read, understood and adhered to our contributing document.

  • [x] Ensure that you were first assigned to a relevant issue before creating this pull request
  • [ ] Ensure code changes pass all tests

• [x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.

• [x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request

• [x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123

• [ ] Set this pull request to 'draft' if you are still working on it

• [x] Resolved any merge conflicts

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

[swetharnaik]

@knjk04 I have raised PR but I have some queries/issues that I found during development-

1. During development, while trying to get authors/awards fields also from findAllBooks query, I used to get the below exception- Caused by: org.hibernate.LazyInitializationException: failed to lazily initialize a collection of role: com.karankumar.booksapi.model.Book.awards, could not initialize proxy - no Session

This was because the FetchType was LAZY. When I changed it to EAGER, I got the proper output as seen below

2. The test cases written for the repository class are failing because of the deletion call which doesn't get execute successfully. It gets blocked because of its reference (foreign key) in another table. For example, in AuthorRepositoryTest, while trying to call deleteAll(), it will throw an DataIntegrityViolationException because author_id is present in book_award table as well. On making the CascadeType to REMOVE, this was successfully resolved.

If these are valid issues that are currently present, can I make these changes?

[knjk04]

@swetharnaik Thanks for raising the PR & apologies for the slow response. I'll get back to you on this.

[swetharnaik]

@knjk04 Sure no problem.

[knjk04]

Sorry for not getting back to you sooner.

1. Ideally, we would be using lazy for performance reasons. Are you able to get this to work if you just use a join?

2. That should be fine

[knjk04]

@swetharnaik How are you getting on with this?

[swetharnaik]

@knjk04 Apologies for the late reply. Will work on it this week. Need to integrate with latest updates and check.

[knjk04]

@swetharnaik How are you getting on with this?

[knjk04]

@swetharnaik Closing due to no response (as per our contributing guidelines)