Project-Books / books-api

GraphQL Books API
https://project-books.github.io/#books-api
MIT License
35 stars 61 forks source link

Add mutation to delete an Author and all of its books #112

Closed Syemon closed 2 years ago

Syemon commented 3 years ago

Summary of change

Added mutation which allows delete author with its books (only if there are no relations with other authors left). I had to delete V010__RENAME_PUBLISHER_BOOK_CONSTRAINTS.sql during development.

Related issue

Closes #90

Pull request checklist

Please keep this checklist in & ensure you have done the following:

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

knjk04 commented 3 years ago

@Syemon Thanks for making the changes. It looks like the build is failing: https://github.com/Project-Books/books-api/pull/112/checks?check_run_id=3713998068#step:6:1693. Could you please take a look into this?

Syemon commented 3 years ago

@Syemon Thanks for making the changes. It looks like the build is failing: https://github.com/Project-Books/books-api/pull/112/checks?check_run_id=3713998068#step:6:1693. Could you please take a look into this?

There were issues with dependencies. I have updated my branch to the newest changes.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 18 Code Smells

96.9% 96.9% Coverage
0.0% 0.0% Duplication