Closed Syemon closed 2 years ago
@Syemon Thanks for making the changes. It looks like the build is failing: https://github.com/Project-Books/books-api/pull/112/checks?check_run_id=3713998068#step:6:1693. Could you please take a look into this?
@Syemon Thanks for making the changes. It looks like the build is failing: https://github.com/Project-Books/books-api/pull/112/checks?check_run_id=3713998068#step:6:1693. Could you please take a look into this?
There were issues with dependencies. I have updated my branch to the newest changes.
Kudos, SonarCloud Quality Gate passed!
Summary of change
Added mutation which allows delete author with its books (only if there are no relations with other authors left). I had to delete
V010__RENAME_PUBLISHER_BOOK_CONSTRAINTS.sql
during development.Related issue
Closes #90
Pull request checklist
Please keep this checklist in & ensure you have done the following:
[x] Read, understood and adhered to our contributing document.
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g.
test-reading-goal-123
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub