Closed hsteinmueller closed 3 years ago
Hi @hsteinmueller, thanks for working on this. Unfortunately, this violates our contributing guidelines, as we request that you first request to be assigned to avoid duplicated work (someone is already assigned to this issue).
If this issue becomes available (if the person assigned to it doesn't respond within our time frame and the next person who enquiried on the issue also doesn't want to work on this or doesn't respond, we can offer this to you).
Summary of change
Added spring-security with
ADMIN
role. There is no use for aUSER
role by now since queries should be allowed for everyone. If it is need it can be added easily.Mutations are only allowed for
ADMIN
while queries are allowed for everyone.Related issue
Closes #69
Pull request checklist
Please keep this checklist in & ensure you have done the following:
[x] Read, understood and adhered to our contributing document.
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g.
test-reading-goal-123
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub