Project-Books / books-api

GraphQL Books API
https://project-books.github.io/#books-api
MIT License
36 stars 61 forks source link

Add security to mutations #133

Closed hsteinmueller closed 3 years ago

hsteinmueller commented 3 years ago

Summary of change

Added spring-security with ADMIN role. There is no use for a USER role by now since queries should be allowed for everyone. If it is need it can be added easily.

Mutations are only allowed for ADMIN while queries are allowed for everyone.

Related issue

Closes #69

Pull request checklist

Please keep this checklist in & ensure you have done the following:

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

knjk04 commented 3 years ago

Hi @hsteinmueller, thanks for working on this. Unfortunately, this violates our contributing guidelines, as we request that you first request to be assigned to avoid duplicated work (someone is already assigned to this issue).

If this issue becomes available (if the person assigned to it doesn't respond within our time frame and the next person who enquiried on the issue also doesn't want to work on this or doesn't respond, we can offer this to you).