Jacoco report exclude 122

Wildschut commented 3 years ago

Summary of change

Attempt to Narrowing the Focus of sonarqube code coverage regarding the files/paths mentioned in the issue.

Closes #122

Please keep this checklist in & ensure you have done the following:

[x] Read, understood and adhered to our contributing document.
- [x] Ensure that you were first assigned to a relevant issue before creating this pull request
- [x] Ensure code changes pass all tests
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts

For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.

If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

No Coverage information
0.0% Duplication

knjk04 commented 3 years ago

@Wildschut Is this ready to be merged in?

Wildschut commented 3 years ago

Just to recap on the pr,

the goal of this commit was to exclude the BooksApiApplication class and all the model classes from code coverage.

As far as I can tell, the jacoco report is excluding it. But sonarcloud wasn't. This commit addresses that.

How do I verify the results? The build check doesn't show code coverage results just the files changed...

knjk04 commented 3 years ago

@Wildschut Apologies for the late reply. Thanks for the recap!

This looks good to me, so I'll merge this in. If it doesn't change the code coverage, I'll edit the exclusions manually in SonarCloud.

Thanks for your help with this!

knjk04 commented 3 years ago

@Wildschut Apologies for the late reply. Thanks for the recap!

This looks good to me, so I'll merge this in. If it doesn't change the code coverage, I'll edit the exclusions manually in SonarCloud.

Thanks for your help with this!