Closed jhanna60 closed 2 years ago
Hey I realised IntelliJ tried to optimise imports for me and inserted a wildcard violating style guides, I've since amended this.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell
No Coverage information
0.0% Duplication
Summary of change
I have added the ability to now return covers in our GraphQL query, this is done in the form of a String to the path of the cover, I have also amended the DB scripts to reflect my changes, I have removed Cover_ID from the books table and all relationships going forward will be determined in the covers table allowing for multiple covers per book. We no longer needed the DB script to add cover ID so I removed this. I also added book primary key to the covers table and as this has a dependency on books I needed to move the script AFTER books were inserted. This left a gap in the sequence of scripts so I renamed them to bring them back in numerical order. Finally I also modified the README file to reflect the new format to supply to receive Covers, I also noticed that publisher didn't work so I renamed this to publishers and now the sample query works. The only thing slightly annoying me is that I had to set Cover fetching to type EAGER otherwise this wouldn't work, however I have noticed other objects also not loading correctly using LAZY but we don't reference them just yet so its a more deep rooted issue overall.
Related issue
Closes #131
Pull request checklist
Please keep this checklist in & ensure you have done the following:
[x] Read, understood and adhered to our contributing document.
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g. test-reading-goal-123
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts
For any checkbox that does not apply, still check it.
If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub