Closed hpa16 closed 2 years ago
@hpa16 Thanks a lot for working on adding awards! I'm still reviewing this, but so far so good! I've made one small change where I added a missing assertion
Kudos, SonarCloud Quality Gate passed!
@hpa16 How are you getting on with the changes requested?
@knjk04 Apologies, I was not able to work on this yet but can do it this week.
Kudos, SonarCloud Quality Gate passed!
@hpa16 How are you getting on with this? Let us know if you need a hand
@hpa16 Closing due to no reply
Hi @knjk04, do you mean the year a book wins an award should be stored in the book_award table which connects the two entities? If so, I think it can be a separated out from the scope of this PR.
Kudos, SonarCloud Quality Gate passed!
Hi @hpa16, I was thinking that we should store when a particular book won a particular award and the year that it won the award. However, I'm happy to separate that out and merge this in. Thanks for your help with this!
Thanks @knjk04 for your guidance!
Summary of change
Added awards entity with awardName as an enum. Added a query to get all books that have won a certain award Added mutations to add or delete awards DB migration: Added 2 books through INSERT_BOOK_AWARDS.sql to showcase the books-awards link
Related issue
Closes #15
Pull request checklist
Please keep this checklist in & ensure you have done the following:
[x] Read, understood and adhered to our contributing document.
[x] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[x] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[x] Set this pull request to 'draft' if you are still working on it
[x] Resolved any merge conflicts
For any checkbox that does not apply, still check it.
If in doubt, get in touch with us via our Slack workspace or by creating a new Q&A discussion on GitHub