Project-Books / books-api

GraphQL Books API
https://project-books.github.io/#books-api
MIT License
35 stars 60 forks source link

Add literary awards won #15

Closed knjk04 closed 2 years ago

knjk04 commented 3 years ago

Add a literary award won entity

Fields:

It should be possible to search for all of the award winners of a literary award (we could use a derived query here).

mparkersimms commented 3 years ago

I'd like to work on this issue if that's alright with you?

knjk04 commented 3 years ago

Thanks for your interest in this! We only assign at most issue at a time for new contributors (see https://project-books.github.io/docs/contributing/#new-contributors-assigned-to-at-most-one-issue-at-a-time), but we'd be happy to assign you to this if it's still available after we've merged in a pull request for your currently assigned issue

swetharnaik commented 3 years ago

@knjk04 Could I work on this issue?

knjk04 commented 3 years ago

@swetharnaik Sure, thanks a lot! Note that I've updated the issue description

swetharnaik commented 3 years ago

@knjk04 Have added Award entity. Please check output below. If all is good, will raise a PR. image

knjk04 commented 3 years ago

@swetharnaik Thanks, this looks good! Would it be possible to remove 'IgnoreCase' from the method name and trim the input award name for leading or trailing whitespace if you haven't done so already?

swetharnaik commented 3 years ago

@knjk04 Sure

hpa16 commented 2 years ago

Hi @knjk04 I'd like to work on this if it's available now.

knjk04 commented 2 years ago

Hi @hpa16, thanks! I'll assign you to it!