Project-Books / books-api

GraphQL Books API
https://project-books.github.io/#books-api
MIT License
35 stars 61 forks source link

Store the year a book won an award #158

Open knjk04 opened 2 years ago

knjk04 commented 2 years ago

Describe the solution you'd like If a book wins an award, we should be able to show the year it won that award

Additional context

If you need help with anything, we'll be happy to help you over a GitHub Q&A discussion or our Slack workspace

emsnguyen commented 2 years ago

Hi Karan I am a newbie to open source and I find your project interesting so I would like to be a part. Below are what I am thinking about the problem you are having, I look forward to your reply.

  1. Implementation approach Input: Id of a particular book Output: the award name and the year the book won that award. Since a book can win many awards, the response should be a list I guess. If no award is found for the book, return an empty list.

I intend to select the awards associated with the book id via the book_award table, then refers to award table to get the award name and year. I have one question, though. Is the "year" column in the award table means the year a book wins that award (which means that award is fixed to one particular year)? If not, I intend to add a "winning_year" property to the book_award table.

  1. Estimate: 10 hours of coding and testing (this is my first time with open source so I am not quite sure, but I will do my best to finish this by the end of this week (April 24th 2022)
ddninja commented 2 years ago

hi @knjk04 , is this issue still open?

ShubhraSuman commented 2 years ago

Can you assign this to me?

sushmitha-malae commented 2 years ago

Interested in contributing to this issue, can you assign to me.