Closed chetanchilhate closed 3 years ago
@knjk04 this one has updated master
@knjk04 did you checked the pr, let me know if you have any feedback
@chetanchilhate Not yet, I'll take a look shortly
@chetanchilhate Thanks for working on this. I noticed the issue number is 18, not 2. You'll need to rename your branch (git branch -m <new-name>
) and create a new PR. When you do, could you also please fill in the PR template?
Summary of change
[Please briefly describe what you have changed.]
Related issue
Closes #[issue number]
Pull request checklist
Please keep this checklist in & ensure you have done the following:
[ ] Read, understood and adhered to our contributing document.
[ ] Read, understood and adhered to our style guide. A lot of our code reviews are spent on ensuring compliance with our style guide, so it would save a lot of time if this was adhered to from the outset.
[ ] Filled in the summary, context (if applicable) and related issue section. Replace the square brackets and its placeholder content with your contents. For an example, see any merged in pull request
[ ] Created a branch that has a descriptive name (what your branch is for in a few words and includes the issue number at the end, e.g.
test-reading-goal-123
[ ] Set this pull request to 'draft' if you are still working on it
[ ] Resolved any merge conflicts
For any of the optional checkboxes (e.g. the screenshots one), still check it if it does not apply.
If in doubt, get in touch with us via our Slack workspace